mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-28 14:44:10 +08:00
vfs: clean up vfs_rmdir
Simplify the control flow with an out label. Signed-off-by: Sage Weil <sage@newdream.net> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
parent
b5afd2c406
commit
912dbc15d9
35
fs/namei.c
35
fs/namei.c
@ -2563,23 +2563,26 @@ int vfs_rmdir(struct inode *dir, struct dentry *dentry)
|
|||||||
return -EPERM;
|
return -EPERM;
|
||||||
|
|
||||||
mutex_lock(&dentry->d_inode->i_mutex);
|
mutex_lock(&dentry->d_inode->i_mutex);
|
||||||
if (d_mountpoint(dentry))
|
|
||||||
error = -EBUSY;
|
|
||||||
else {
|
|
||||||
error = security_inode_rmdir(dir, dentry);
|
|
||||||
if (!error) {
|
|
||||||
error = dir->i_op->rmdir(dir, dentry);
|
|
||||||
if (!error) {
|
|
||||||
dentry->d_inode->i_flags |= S_DEAD;
|
|
||||||
dont_mount(dentry);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
mutex_unlock(&dentry->d_inode->i_mutex);
|
|
||||||
if (!error) {
|
|
||||||
d_delete(dentry);
|
|
||||||
}
|
|
||||||
|
|
||||||
|
error = -EBUSY;
|
||||||
|
if (d_mountpoint(dentry))
|
||||||
|
goto out;
|
||||||
|
|
||||||
|
error = security_inode_rmdir(dir, dentry);
|
||||||
|
if (error)
|
||||||
|
goto out;
|
||||||
|
|
||||||
|
error = dir->i_op->rmdir(dir, dentry);
|
||||||
|
if (error)
|
||||||
|
goto out;
|
||||||
|
|
||||||
|
dentry->d_inode->i_flags |= S_DEAD;
|
||||||
|
dont_mount(dentry);
|
||||||
|
|
||||||
|
out:
|
||||||
|
mutex_unlock(&dentry->d_inode->i_mutex);
|
||||||
|
if (!error)
|
||||||
|
d_delete(dentry);
|
||||||
return error;
|
return error;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user