mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-26 05:34:13 +08:00
power_supply: charger-manager: add missing of_node_put
for_each_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ expression root,e; local idexpression child; @@ for_each_child_of_node(root, child) { ... when != of_node_put(child) when != e = child ( return child; | + of_node_put(child); ? return ...; ) ... } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by: Sebastian Reichel <sre@kernel.org>
This commit is contained in:
parent
6169588f69
commit
8e5cfb74bc
@ -1581,8 +1581,10 @@ static struct charger_desc *of_cm_parse_desc(struct device *dev)
|
||||
cables = devm_kzalloc(dev, sizeof(*cables)
|
||||
* chg_regs->num_cables,
|
||||
GFP_KERNEL);
|
||||
if (!cables)
|
||||
if (!cables) {
|
||||
of_node_put(child);
|
||||
return ERR_PTR(-ENOMEM);
|
||||
}
|
||||
|
||||
chg_regs->cables = cables;
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user