korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-11 21:14:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

gpio: exar: switch to a simpler IDA interface

Browse Source 
We don't need to specify any ranges when allocating IDs so we can switch
to ida_alloc() and ida_free() instead of the ida_simple_ counterparts.

ida_simple_get(ida, 0, 0, gfp) is equivalent to
ida_alloc_range(ida, 0, UINT_MAX, gfp) which is equivalent to
ida_alloc(ida, gfp). Note: IDR will never actually allocate an ID
larger than INT_MAX.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
This commit is contained in:
Bartosz Golaszewski 2020-09-28 14:35:51 +02:00
parent 26ced453a5
commit 8e27c2aef8
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/gpio/gpio-exar.c
View File

@ -149,7 +149,7 @@ static int gpio_exar_probe(struct platform_device *pdev)
mutex_init(&exar_gpio->lock); mutex_init(&exar_gpio->lock);
index = ida_simple_get(&ida_index, 0, 0, GFP_KERNEL); index = ida_alloc(&ida_index, GFP_KERNEL);
if (index < 0) { if (index < 0) {
ret = index; ret = index;
goto err_mutex_destroy; goto err_mutex_destroy;
@ -179,7 +179,7 @@ static int gpio_exar_probe(struct platform_device *pdev)
return 0; return 0;
err_destroy: err_destroy:
ida_simple_remove(&ida_index, index); ida_free(&ida_index, index);
err_mutex_destroy: err_mutex_destroy:
mutex_destroy(&exar_gpio->lock); mutex_destroy(&exar_gpio->lock);
return ret; return ret;
@ -189,7 +189,7 @@ static int gpio_exar_remove(struct platform_device *pdev)
{ {
struct exar_gpio_chip *exar_gpio = platform_get_drvdata(pdev); struct exar_gpio_chip *exar_gpio = platform_get_drvdata(pdev);
ida_simple_remove(&ida_index, exar_gpio->index); ida_free(&ida_index, exar_gpio->index);
mutex_destroy(&exar_gpio->lock); mutex_destroy(&exar_gpio->lock);
return 0; return 0;