korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-02 00:24:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

defxx: Correct DEFEA's ESIC port I/O accesses

Browse Source 
Reverse the order of arguments to `outb', data to write comes first.

Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Maciej W. Rozycki 2014-09-25 11:06:39 +01:00 committed by David S. Miller
parent f5c7e1a47a
commit 8a189f1288
1 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
drivers/net/fddi/defxx.c
View File

@ -719,28 +719,28 @@ static void dfx_bus_init(struct net_device *dev)
/* Set the decode range of the board. */ /* Set the decode range of the board. */
val = ((bp->base.port >> 12) << PI_IO_CMP_V_SLOT); val = ((bp->base.port >> 12) << PI_IO_CMP_V_SLOT);
outb(base_addr + PI_ESIC_K_IO_ADD_CMP_0_1, val); outb(val, base_addr + PI_ESIC_K_IO_ADD_CMP_0_1);
outb(base_addr + PI_ESIC_K_IO_ADD_CMP_0_0, 0); outb(0, base_addr + PI_ESIC_K_IO_ADD_CMP_0_0);
outb(base_addr + PI_ESIC_K_IO_ADD_CMP_1_1, val); outb(val, base_addr + PI_ESIC_K_IO_ADD_CMP_1_1);
outb(base_addr + PI_ESIC_K_IO_ADD_CMP_1_0, 0); outb(0, base_addr + PI_ESIC_K_IO_ADD_CMP_1_0);
val = PI_ESIC_K_CSR_IO_LEN - 1; val = PI_ESIC_K_CSR_IO_LEN - 1;
outb(base_addr + PI_ESIC_K_IO_ADD_MASK_0_1, (val >> 8) & 0xff); outb(val, base_addr + PI_ESIC_K_IO_ADD_MASK_0_1);
outb(base_addr + PI_ESIC_K_IO_ADD_MASK_0_0, val & 0xff); outb(0, base_addr + PI_ESIC_K_IO_ADD_MASK_0_0);
outb(base_addr + PI_ESIC_K_IO_ADD_MASK_1_1, (val >> 8) & 0xff); outb(val, base_addr + PI_ESIC_K_IO_ADD_MASK_1_1);
outb(base_addr + PI_ESIC_K_IO_ADD_MASK_1_0, val & 0xff); outb(0, base_addr + PI_ESIC_K_IO_ADD_MASK_1_0);
/* Enable the decoders. */ /* Enable the decoders. */
val = PI_FUNCTION_CNTRL_M_IOCS1 | PI_FUNCTION_CNTRL_M_IOCS0; val = PI_FUNCTION_CNTRL_M_IOCS1 | PI_FUNCTION_CNTRL_M_IOCS0;
if (dfx_use_mmio) if (dfx_use_mmio)
val |= PI_FUNCTION_CNTRL_M_MEMCS0; val |= PI_FUNCTION_CNTRL_M_MEMCS0;
outb(base_addr + PI_ESIC_K_FUNCTION_CNTRL, val); outb(val, base_addr + PI_ESIC_K_FUNCTION_CNTRL);
/* /*
* Enable access to the rest of the module * Enable access to the rest of the module
* (including PDQ and packet memory). * (including PDQ and packet memory).
*/ */
val = PI_SLOT_CNTRL_M_ENB; val = PI_SLOT_CNTRL_M_ENB;
outb(base_addr + PI_ESIC_K_SLOT_CNTRL, val); outb(val, base_addr + PI_ESIC_K_SLOT_CNTRL);
/* /*
* Map PDQ registers into memory or port space. This is * Map PDQ registers into memory or port space. This is
@ -751,12 +751,12 @@ static void dfx_bus_init(struct net_device *dev)
val |= PI_BURST_HOLDOFF_V_MEM_MAP; val |= PI_BURST_HOLDOFF_V_MEM_MAP;
else else
val &= ~PI_BURST_HOLDOFF_V_MEM_MAP; val &= ~PI_BURST_HOLDOFF_V_MEM_MAP;
outb(base_addr + PI_DEFEA_K_BURST_HOLDOFF, val); outb(val, base_addr + PI_DEFEA_K_BURST_HOLDOFF);
/* Enable interrupts at EISA bus interface chip (ESIC) */ /* Enable interrupts at EISA bus interface chip (ESIC) */
val = inb(base_addr + PI_ESIC_K_IO_CONFIG_STAT_0); val = inb(base_addr + PI_ESIC_K_IO_CONFIG_STAT_0);
val |= PI_CONFIG_STAT_0_M_INT_ENB; val |= PI_CONFIG_STAT_0_M_INT_ENB;
outb(base_addr + PI_ESIC_K_IO_CONFIG_STAT_0, val); outb(val, base_addr + PI_ESIC_K_IO_CONFIG_STAT_0);
} }
if (dfx_bus_pci) { if (dfx_bus_pci) {
struct pci_dev *pdev = to_pci_dev(bdev); struct pci_dev *pdev = to_pci_dev(bdev);
@ -825,7 +825,7 @@ static void dfx_bus_uninit(struct net_device *dev)
/* Disable interrupts at EISA bus interface chip (ESIC) */ /* Disable interrupts at EISA bus interface chip (ESIC) */
val = inb(base_addr + PI_ESIC_K_IO_CONFIG_STAT_0); val = inb(base_addr + PI_ESIC_K_IO_CONFIG_STAT_0);
val &= ~PI_CONFIG_STAT_0_M_INT_ENB; val &= ~PI_CONFIG_STAT_0_M_INT_ENB;
outb(base_addr + PI_ESIC_K_IO_CONFIG_STAT_0, val); outb(val, base_addr + PI_ESIC_K_IO_CONFIG_STAT_0);
} }
if (dfx_bus_pci) { if (dfx_bus_pci) {
/* Disable interrupts at PCI bus interface chip (PFI) */ /* Disable interrupts at PCI bus interface chip (PFI) */
@ -1917,7 +1917,7 @@ static irqreturn_t dfx_interrupt(int irq, void *dev_id)
/* Disable interrupts at the ESIC */ /* Disable interrupts at the ESIC */
status &= ~PI_CONFIG_STAT_0_M_INT_ENB; status &= ~PI_CONFIG_STAT_0_M_INT_ENB;
outb(base_addr + PI_ESIC_K_IO_CONFIG_STAT_0, status); outb(status, base_addr + PI_ESIC_K_IO_CONFIG_STAT_0);
/* Call interrupt service routine for this adapter */ /* Call interrupt service routine for this adapter */
dfx_int_common(dev); dfx_int_common(dev);
@ -1925,7 +1925,7 @@ static irqreturn_t dfx_interrupt(int irq, void *dev_id)
/* Reenable interrupts at the ESIC */ /* Reenable interrupts at the ESIC */
status = inb(base_addr + PI_ESIC_K_IO_CONFIG_STAT_0); status = inb(base_addr + PI_ESIC_K_IO_CONFIG_STAT_0);
status |= PI_CONFIG_STAT_0_M_INT_ENB; status |= PI_CONFIG_STAT_0_M_INT_ENB;
outb(base_addr + PI_ESIC_K_IO_CONFIG_STAT_0, status); outb(status, base_addr + PI_ESIC_K_IO_CONFIG_STAT_0);
spin_unlock(&bp->lock); spin_unlock(&bp->lock);
} }