korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2025-01-18 11:54:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

writeback: fix break condition

Browse Source 
Commit dcf6a79dda ("write-back: fix
nr_to_write counter") fixed nr_to_write counter, but didn't set the break
condition properly.

If nr_to_write == 0 after being decremented it will loop one more time
before setting done = 1 and breaking the loop.

[akpm@linux-foundation.org: coding-style fixes]
Cc: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Acked-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Federico Cuello 2009-02-11 13:04:39 -08:00 committed by Linus Torvalds
parent 6c5979631b
commit 89e1219004
1 changed files with 16 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
mm/page-writeback.c
View File

@ -1051,20 +1051,23 @@ continue_unlock:
} }
} }
if (nr_to_write > 0) if (nr_to_write > 0) {
nr_to_write--; nr_to_write--;
else if (wbc->sync_mode == WB_SYNC_NONE) { if (nr_to_write == 0 &&
/* wbc->sync_mode == WB_SYNC_NONE) {
* We stop writing back only if we are not /*
* doing integrity sync. In case of integrity * We stop writing back only if we are
* sync we have to keep going because someone * not doing integrity sync. In case of
* may be concurrently dirtying pages, and we * integrity sync we have to keep going
* might have synced a lot of newly appeared * because someone may be concurrently
* dirty pages, but have not synced all of the * dirtying pages, and we might have
* old dirty pages. * synced a lot of newly appeared dirty
*/ * pages, but have not synced all of the
done = 1; * old dirty pages.
break; */
done = 1;
break;
}
} }
if (wbc->nonblocking && bdi_write_congested(bdi)) { if (wbc->nonblocking && bdi_write_congested(bdi)) {