korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-25 05:04:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

net: avoid quadratic behavior in netdev_wait_allrefs_any()

Browse Source 
If the list of devices has N elements, netdev_wait_allrefs_any()
is called N times, and linkwatch_forget_dev() is called N*(N-1)/2 times.

Fix this by calling linkwatch_forget_dev() only once per device.

Fixes: faab39f63c ("net: allow out-of-order netdev unregistration")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20220218065430.2613262-1-eric.dumazet@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Eric Dumazet 2022-02-17 22:54:30 -08:00 committed by Jakub Kicinski
parent 086d49058c
commit 86213f80da
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/core/dev.c
View File

@ -9828,9 +9828,6 @@ static struct net_device *netdev_wait_allrefs_any(struct list_head *list)
struct net_device *dev;
int wait = 0;
list_for_each_entry(dev, list, todo_list)
linkwatch_forget_dev(dev);
rebroadcast_time = warning_time = jiffies;
list_for_each_entry(dev, list, todo_list)
@ -9951,6 +9948,7 @@ void netdev_run_todo(void)
}
dev->reg_state = NETREG_UNREGISTERED;
linkwatch_forget_dev(dev);
}
while (!list_empty(&list)) {