korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-11 04:18:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

core_pattern: add CPU specifier

Browse Source 
Statistically, in a large deployment regular segfaults may indicate a CPU
issue.

Currently, it is not possible to find out what CPU the segfault happened
on.  There are at least two attempts to improve segfault logging with this
regard, but they do not help in case the logs rotate.

Hence, lets make sure it is possible to permanently record a CPU the task
ran on using a new core_pattern specifier.

Link: https://lkml.kernel.org/r/20220903064330.20772-1-oleksandr@redhat.com
Signed-off-by: Oleksandr Natalenko <oleksandr@redhat.com>
Suggested-by: Renaud Métrich <rmetrich@redhat.com>
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: "Eric W . Biederman" <ebiederm@xmission.com>
Cc: Grzegorz Halat <ghalat@redhat.com>
Cc: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: "Huang, Ying" <ying.huang@intel.com>
Cc: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: Joel Savitz <jsavitz@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Kees Cook <keescook@chromium.org>
Cc: Laurent Dufour <ldufour@linux.ibm.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Stephen Kitt <steve@sk2.org>
Cc: Will Deacon <will@kernel.org>
Cc: Xiaoming Ni <nixiaoming@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Oleksandr Natalenko 2022-09-03 08:43:30 +02:00 committed by Andrew Morton
parent 597d77d29c
commit 8603b6f586
3 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Documentation/admin-guide/sysctl/kernel.rst
View File

@ -174,6 +174,7 @@ core_pattern
%f executable filename %f executable filename
%E executable path %E executable path
%c maximum size of core file by resource limit RLIMIT_CORE %c maximum size of core file by resource limit RLIMIT_CORE
%C CPU the task ran on
%<OTHER> both are dropped %<OTHER> both are dropped
======== ========================================== ======== ==========================================

5
fs/coredump.c
View File

@ -325,6 +325,10 @@ static int format_corename(struct core_name *cn, struct coredump_params *cprm,
err = cn_printf(cn, "%lu", err = cn_printf(cn, "%lu",
rlimit(RLIMIT_CORE)); rlimit(RLIMIT_CORE));
break; break;
/* CPU the task ran on */
case 'C':
err = cn_printf(cn, "%d", cprm->cpu);
break;
default: default:
break; break;
} }
@ -534,6 +538,7 @@ void do_coredump(const kernel_siginfo_t *siginfo)
*/ */
.mm_flags = mm->flags, .mm_flags = mm->flags,
.vma_meta = NULL, .vma_meta = NULL,
.cpu = raw_smp_processor_id(),
}; };
audit_core_dumps(siginfo->si_signo); audit_core_dumps(siginfo->si_signo);

1
include/linux/coredump.h
View File

@ -22,6 +22,7 @@ struct coredump_params {
struct file *file; struct file *file;
unsigned long limit; unsigned long limit;
unsigned long mm_flags; unsigned long mm_flags;
int cpu;
loff_t written; loff_t written;
loff_t pos; loff_t pos;
loff_t to_skip; loff_t to_skip;