regulator: fixed: Ensure enable_counter is correct if reg_domain_disable fails

dev_pm_genpd_set_performance_state() may fail, so had better to check it's
return value before decreasing priv->enable_counter.

Fixes: bf3a28cf42 ("regulator: fixed: support using power domain for enable/disable")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Link: https://lore.kernel.org/r/20210520111811.1806293-1-axel.lin@ingics.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Axel Lin 2021-05-20 19:18:11 +08:00 committed by Mark Brown
parent 687c9e3b1a
commit 855bfff9d6
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0

View File

@ -88,10 +88,15 @@ static int reg_domain_disable(struct regulator_dev *rdev)
{
struct fixed_voltage_data *priv = rdev_get_drvdata(rdev);
struct device *dev = rdev->dev.parent;
int ret;
ret = dev_pm_genpd_set_performance_state(dev, 0);
if (ret)
return ret;
priv->enable_counter--;
return dev_pm_genpd_set_performance_state(dev, 0);
return 0;
}
static int reg_is_enabled(struct regulator_dev *rdev)