korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-15 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

wifi: cw1200: restore endian swapping

Browse Source 
The code here looks well thought-out, so it seems likely
that the byte-swaps are actually needed, due to SPI bus
and device behaviour. Restore the byte-swapping, in a way
that doesn't result in sparse warnings.

Fixes: 7ceade6534 ("wifi: cw1200: fix __le16 sparse warnings")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/20240228121156.62f820aa6dfb.Ia63314e4d0ed1ee76f100846d68f0722abf6b793@changeid
This commit is contained in:
Johannes Berg 2024-02-28 12:11:56 +01:00 committed by Kalle Valo
parent f6e36d9e1c
commit 81e060584f
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/wireless/st/cw1200/cw1200_spi.c
View File

@ -81,6 +81,9 @@ static int cw1200_spi_memcpy_fromio(struct hwbus_priv *self,
pr_info("READ : %04d from 0x%02x (%04x)\n", count, addr, regaddr); pr_info("READ : %04d from 0x%02x (%04x)\n", count, addr, regaddr);
#endif #endif
/* Header is LE16 */
regaddr = (__force u16)cpu_to_le16(regaddr);
/* We have to byteswap if the SPI bus is limited to 8b operation /* We have to byteswap if the SPI bus is limited to 8b operation
or we are running on a Big Endian system or we are running on a Big Endian system
*/ */
@ -143,6 +146,9 @@ static int cw1200_spi_memcpy_toio(struct hwbus_priv *self,
pr_info("WRITE: %04d to 0x%02x (%04x)\n", count, addr, regaddr); pr_info("WRITE: %04d to 0x%02x (%04x)\n", count, addr, regaddr);
#endif #endif
/* Header is LE16 */
regaddr = (__force u16)cpu_to_le16(regaddr);
/* We have to byteswap if the SPI bus is limited to 8b operation /* We have to byteswap if the SPI bus is limited to 8b operation
or we are running on a Big Endian system or we are running on a Big Endian system
*/ */