korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-13 22:14:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

drm/connector: Make ->atomic_commit() optional

Browse Source 
Not all writeback connector implementations might want to commit things
from the connector driver. Some, like the malidp driver, commit things
from their main commit_tail() function, and would rather not have to
implement a dummy hook for drm_connector_helper_funcs.atomic_commit().

Make this function optional and reflect this fact in the doc.

Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180703075022.15138-4-boris.brezillon@bootlin.com
This commit is contained in:
Boris Brezillon 2018-07-03 09:50:17 +02:00
parent 425132fdb1
commit 814bde99ee
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/drm_atomic_helper.c
View File

@ -1184,6 +1184,8 @@ static void drm_atomic_helper_commit_writebacks(struct drm_device *dev,
const struct drm_connector_helper_funcs *funcs; const struct drm_connector_helper_funcs *funcs;
funcs = connector->helper_private; funcs = connector->helper_private;
if (!funcs->atomic_commit)
continue;
if (new_conn_state->writeback_job && new_conn_state->writeback_job->fb) { if (new_conn_state->writeback_job && new_conn_state->writeback_job->fb) {
WARN_ON(connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK); WARN_ON(connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK);

2
include/drm/drm_modeset_helper_vtables.h
View File

@ -983,6 +983,8 @@ struct drm_connector_helper_funcs {
* The writeback_job to commit is available in * The writeback_job to commit is available in
* &drm_connector_state.writeback_job. * &drm_connector_state.writeback_job.
* *
* This hook is optional.
*
* This callback is used by the atomic modeset helpers. * This callback is used by the atomic modeset helpers.
*/ */
void (*atomic_commit)(struct drm_connector *connector, void (*atomic_commit)(struct drm_connector *connector,