mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-29 15:14:18 +08:00
net: bridge: use switchdev for port flags set through sysfs too
Looking through patchwork I don't see that there was any consensus to
use switchdev notifiers only in case of netlink provided port flags but
not sysfs (as a sort of deprecation, punishment or anything like that),
so we should probably keep the user interface consistent in terms of
functionality.
http://patchwork.ozlabs.org/project/netdev/patch/20170605092043.3523-3-jiri@resnulli.us/
http://patchwork.ozlabs.org/project/netdev/patch/20170608064428.4785-3-jiri@resnulli.us/
Fixes: 3922285d96
("net: bridge: Add support for offloading port attributes")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
373e13bc63
commit
8043c845b6
@ -59,9 +59,8 @@ static BRPORT_ATTR(_name, 0644, \
|
||||
static int store_flag(struct net_bridge_port *p, unsigned long v,
|
||||
unsigned long mask)
|
||||
{
|
||||
unsigned long flags;
|
||||
|
||||
flags = p->flags;
|
||||
unsigned long flags = p->flags;
|
||||
int err;
|
||||
|
||||
if (v)
|
||||
flags |= mask;
|
||||
@ -69,6 +68,10 @@ static int store_flag(struct net_bridge_port *p, unsigned long v,
|
||||
flags &= ~mask;
|
||||
|
||||
if (flags != p->flags) {
|
||||
err = br_switchdev_set_port_flag(p, flags, mask);
|
||||
if (err)
|
||||
return err;
|
||||
|
||||
p->flags = flags;
|
||||
br_port_flags_change(p, mask);
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user