korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-20 02:34:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

virtio-gpu: Use memdup_user() rather than duplicating its implementation

Browse Source 
Reuse existing functionality from memdup_user() instead of keeping
duplicate source code.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/401e68fc-5515-7a7a-be2e-503dee676b34@users.sourceforge.net
This commit is contained in:
Markus Elfring 2016-08-18 22:35:14 +02:00 committed by Daniel Vetter
parent a6e3918bcd
commit 7ad61e6b4a
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/gpu/drm/virtio/virtgpu_ioctl.c
View File

@ -152,15 +152,10 @@ static int virtio_gpu_execbuffer(struct drm_device *dev,
if (ret) if (ret)
goto out_free; goto out_free;
buf = kmalloc(exbuf->size, GFP_KERNEL); buf = memdup_user((void __user *)(uintptr_t)exbuf->command,
if (!buf) { exbuf->size);
ret = -ENOMEM; if (IS_ERR(buf)) {
goto out_unresv; ret = PTR_ERR(buf);
}
if (copy_from_user(buf, (void __user *)(uintptr_t)exbuf->command,
exbuf->size)) {
kfree(buf);
ret = -EFAULT;
goto out_unresv; goto out_unresv;
} }
virtio_gpu_cmd_submit(vgdev, buf, exbuf->size, virtio_gpu_cmd_submit(vgdev, buf, exbuf->size,