korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-03 09:04:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

perf ui gtk: Drop arg[cv] arguments from perf_gtk_setup_browser()

Browse Source 
As perf doesn't allow to specify gtk command-line option, drop the
arguments and pass NULL to gtk_init().

This makes the function easier to be called from setup_browser().

Signed-off-by: Namhyung Kim <namhyung.kim@lge.com>
Acked-by: Pekka Enberg <penberg@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1335761711-31403-3-git-send-email-namhyung.kim@lge.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Namhyung Kim 2012-04-30 13:55:06 +09:00 committed by Arnaldo Carvalho de Melo
parent ca09b2e1b3
commit 7706f96632
3 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/perf/builtin-report.c
View File

@ -678,7 +678,7 @@ int cmd_report(int argc, const char **argv, const char *prefix __used)
if (strcmp(report.input_name, "-") != 0) { if (strcmp(report.input_name, "-") != 0) {
if (report.use_gtk) if (report.use_gtk)
perf_gtk_setup_browser(argc, argv, true); perf_gtk_setup_browser(true);
else else
setup_browser(true); setup_browser(true);
} else { } else {

5
tools/perf/ui/gtk/browser.c
View File

@ -9,10 +9,9 @@
#define MAX_COLUMNS 32 #define MAX_COLUMNS 32
void perf_gtk_setup_browser(int argc, const char *argv[], void perf_gtk_setup_browser(bool fallback_to_pager __used)
bool fallback_to_pager __used)
{ {
gtk_init(&argc, (char ***)&argv); gtk_init(NULL, NULL);
} }
void perf_gtk_exit_browser(bool wait_for_ok __used) void perf_gtk_exit_browser(bool wait_for_ok __used)

4
tools/perf/util/cache.h
View File

@ -46,14 +46,14 @@ void exit_browser(bool wait_for_ok);
#endif #endif
#ifdef NO_GTK2_SUPPORT #ifdef NO_GTK2_SUPPORT
static inline void perf_gtk_setup_browser(int argc __used, const char *argv[] __used, bool fallback_to_pager) static inline void perf_gtk_setup_browser(bool fallback_to_pager)
{ {
if (fallback_to_pager) if (fallback_to_pager)
setup_pager(); setup_pager();
} }
static inline void perf_gtk_exit_browser(bool wait_for_ok __used) {} static inline void perf_gtk_exit_browser(bool wait_for_ok __used) {}
#else #else
void perf_gtk_setup_browser(int argc, const char *argv[], bool fallback_to_pager); void perf_gtk_setup_browser(bool fallback_to_pager);
void perf_gtk_exit_browser(bool wait_for_ok); void perf_gtk_exit_browser(bool wait_for_ok);
#endif #endif