korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2025-01-10 07:44:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

drm/amdgpu/psp: Fix can't detect psp INVOKE command failed

Browse Source 
There isn't ucode when executing INVOKE command, so current code can't
check the failure of INVOKE command.

Remove the ucode check.

Signed-off-by: Xiangliang Yu <Xiangliang.Yu@amd.com>
Reviewed-by: Feifei Xu <Feifei.Xu@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Xiangliang Yu 2018-12-13 15:34:12 +08:00 committed by Alex Deucher
parent 898e0d9d40
commit 76223c5496
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
View File

@ -140,10 +140,13 @@ psp_cmd_submit_buf(struct psp_context *psp,
while (*((unsigned int *)psp->fence_buf) != index) while (*((unsigned int *)psp->fence_buf) != index)
msleep(1); msleep(1);
/* the status field must be 0 after FW is loaded */ /* the status field must be 0 after psp command completion */
if (ucode && psp->cmd_buf_mem->resp.status) { if (psp->cmd_buf_mem->resp.status) {
DRM_ERROR("failed loading with status (%d) and ucode id (%d)\n", if (ucode)
psp->cmd_buf_mem->resp.status, ucode->ucode_id); DRM_ERROR("failed to load ucode id (%d) ",
ucode->ucode_id);
DRM_ERROR("psp command failed and response status is (%d)\n",
psp->cmd_buf_mem->resp.status);
return -EINVAL; return -EINVAL;
} }