mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-19 02:04:19 +08:00
toshiba_acpi: convert acpi_evaluate_object() to acpi_evaluate_integer()
acpi_evaluate_integer() is an ACPI API introduced to evaluate an ACPI control method that is known to have an integer return value. This API can simplify the code because the calling function does not need to use the specified acpi_buffer structure required by acpi_evaluate_object(); Convert acpi_evaluate_object() to acpi_evaluate_integer() in drivers/platform/x86/toshiba_acpi.c in this patch. Signed-off-by: Zhang Rui <rui.zhang@intel.com> CC: Matthew Garrett <matthew.garrett@nebula.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
parent
4a2d6f6637
commit
74facaf75d
@ -940,21 +940,17 @@ static void toshiba_acpi_hotkey_work(struct work_struct *work)
|
||||
*/
|
||||
static int toshiba_acpi_query_hotkey(struct toshiba_acpi_dev *dev)
|
||||
{
|
||||
struct acpi_buffer buf;
|
||||
union acpi_object out_obj;
|
||||
unsigned long long value;
|
||||
acpi_status status;
|
||||
|
||||
buf.pointer = &out_obj;
|
||||
buf.length = sizeof(out_obj);
|
||||
|
||||
status = acpi_evaluate_object(dev->acpi_dev->handle, "INFO",
|
||||
NULL, &buf);
|
||||
if (ACPI_FAILURE(status) || out_obj.type != ACPI_TYPE_INTEGER) {
|
||||
status = acpi_evaluate_integer(dev->acpi_dev->handle, "INFO",
|
||||
NULL, &value);
|
||||
if (ACPI_FAILURE(status)) {
|
||||
pr_err("ACPI INFO method execution failed\n");
|
||||
return -EIO;
|
||||
}
|
||||
|
||||
return out_obj.integer.value;
|
||||
return value;
|
||||
}
|
||||
|
||||
static void toshiba_acpi_report_hotkey(struct toshiba_acpi_dev *dev,
|
||||
|
Loading…
Reference in New Issue
Block a user