korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-16 16:54:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

ARM: versatile: fix a leaked reference by addingmissing of_node_put

Browse Source 
The call to of_get_next_child returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
./arch/arm/mach-versatile/versatile_dt.c:315:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 302, but without a corresponding object release within this function.
./arch/arm/mach-versatile/versatile_dt.c:320:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 302, but without a corresponding object release within this function.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Wen Yang 2019-03-01 16:56:52 +08:00 committed by Linus Walleij
parent a188339ca5
commit 72187c626e
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
arch/arm/mach-versatile/versatile_dt.c
View File

@ -312,12 +312,12 @@ static void __init versatile_dt_pci_init(void)
* driver had it so we will keep it. * driver had it so we will keep it.
*/ */
writel(1, versatile_sys_base + VERSATILE_SYS_PCICTL_OFFSET); writel(1, versatile_sys_base + VERSATILE_SYS_PCICTL_OFFSET);
return; goto out_put_node;
} }
newprop = kzalloc(sizeof(*newprop), GFP_KERNEL); newprop = kzalloc(sizeof(*newprop), GFP_KERNEL);
if (!newprop) if (!newprop)
return; goto out_put_node;
newprop->name = kstrdup("status", GFP_KERNEL); newprop->name = kstrdup("status", GFP_KERNEL);
newprop->value = kstrdup("disabled", GFP_KERNEL); newprop->value = kstrdup("disabled", GFP_KERNEL);
@ -325,6 +325,9 @@ static void __init versatile_dt_pci_init(void)
of_update_property(np, newprop); of_update_property(np, newprop);
pr_info("Not plugged into PCI backplane!\n"); pr_info("Not plugged into PCI backplane!\n");
out_put_node:
of_node_put(np);
} }
static void __init versatile_dt_init(void) static void __init versatile_dt_init(void)