mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-11 04:18:39 +08:00
scatterlist: don't BUG when we can trivially return a proper error.
There is absolutely no reason to crash the kernel when we have a perfectly good return value already available to use for conveying failure status. Let's return an error code instead of crashing the kernel: that sounds like a much better plan. [akpm@linux-foundation.org: s/E2BIG/EINVAL/] Signed-off-by: Nick Bowler <nbowler@elliptictech.com> Cc: Maxim Levitsky <maximlevitsky@gmail.com> Cc: Tejun Heo <tj@kernel.org> Cc: Jens Axboe <axboe@kernel.dk> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
e71ec59320
commit
6fd59a83b9
@ -248,7 +248,8 @@ int __sg_alloc_table(struct sg_table *table, unsigned int nents,
|
||||
unsigned int left;
|
||||
|
||||
#ifndef ARCH_HAS_SG_CHAIN
|
||||
BUG_ON(nents > max_ents);
|
||||
if (WARN_ON_ONCE(nents > max_ents))
|
||||
return -EINVAL;
|
||||
#endif
|
||||
|
||||
memset(table, 0, sizeof(*table));
|
||||
|
Loading…
Reference in New Issue
Block a user