mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-24 20:54:10 +08:00
perf/smmuv3: Fix hotplug callback leak in arm_smmu_pmu_init()
arm_smmu_pmu_init() won't remove the callback added by cpuhp_setup_state_multi() when platform_driver_register() failed. Remove the callback by cpuhp_remove_multi_state() in fail path. Similar to the handling of arm_ccn_init() in commit26242b3300
("bus: arm-ccn: Prevent hotplug callback leak") Fixes:7d839b4b9e
("perf/smmuv3: Add arm64 smmuv3 pmu driver") Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com> Reviewed-by: Punit Agrawal <punit.agrawal@bytedance.com> Link: https://lore.kernel.org/r/20221115115540.6245-3-shangxiaojing@huawei.com Signed-off-by: Will Deacon <will@kernel.org>
This commit is contained in:
parent
d9f564c966
commit
6f2d566b46
@ -959,6 +959,8 @@ static struct platform_driver smmu_pmu_driver = {
|
||||
|
||||
static int __init arm_smmu_pmu_init(void)
|
||||
{
|
||||
int ret;
|
||||
|
||||
cpuhp_state_num = cpuhp_setup_state_multi(CPUHP_AP_ONLINE_DYN,
|
||||
"perf/arm/pmcg:online",
|
||||
NULL,
|
||||
@ -966,7 +968,11 @@ static int __init arm_smmu_pmu_init(void)
|
||||
if (cpuhp_state_num < 0)
|
||||
return cpuhp_state_num;
|
||||
|
||||
return platform_driver_register(&smmu_pmu_driver);
|
||||
ret = platform_driver_register(&smmu_pmu_driver);
|
||||
if (ret)
|
||||
cpuhp_remove_multi_state(cpuhp_state_num);
|
||||
|
||||
return ret;
|
||||
}
|
||||
module_init(arm_smmu_pmu_init);
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user