korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-29 07:04:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type

Browse Source 
Interrupt line can be configured on different hardware in different way,
even inverted.  Therefore driver should not enforce specific trigger
type - edge falling - but instead rely on Devicetree to configure it.

The Samsung PMIC drivers are used only on Devicetree boards.

Additionally, the PMIC datasheets describe the interrupt line as active
low with a requirement of acknowledge from the CPU therefore the edge
falling is not correct.

Marek Szyprowski reports that together with DTS change (proper level in
DTS) it fixes RTC alarm failure that he observed from time to time on
TM2e board.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20210602110445.33536-1-krzysztof.kozlowski@canonical.com
This commit is contained in:
Krzysztof Kozlowski 2021-06-02 13:04:42 +02:00 committed by Lee Jones
parent b147a05568
commit 6854a10526
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/mfd/sec-irq.c
View File

@ -479,8 +479,7 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic)
} }
ret = devm_regmap_add_irq_chip(sec_pmic->dev, sec_pmic->regmap_pmic, ret = devm_regmap_add_irq_chip(sec_pmic->dev, sec_pmic->regmap_pmic,
sec_pmic->irq, sec_pmic->irq, IRQF_ONESHOT,
IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
0, sec_irq_chip, &sec_pmic->irq_data); 0, sec_irq_chip, &sec_pmic->irq_data);
if (ret != 0) { if (ret != 0) {
dev_err(sec_pmic->dev, "Failed to register IRQ chip: %d\n", ret); dev_err(sec_pmic->dev, "Failed to register IRQ chip: %d\n", ret);