From 658f18d1b82b9f9d89f7c74cd2bcbc9b33a74870 Mon Sep 17 00:00:00 2001 From: Jitendra Bhivare Date: Fri, 26 Aug 2016 15:09:08 +0530 Subject: [PATCH] scsi: be2iscsi: Add missing unlock for mbox_lock Julia pointed out beiscsi_boot_get_sinfo does not unlock mbox_lock on nonemb_cmd memory allocation failure. Signed-off-by: Jitendra Bhivare Reviewed-by: Johannes Thumshirn Signed-off-by: Martin K. Petersen --- drivers/scsi/be2iscsi/be_mgmt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c index b9ff9391dda7..aebc4ddb3060 100644 --- a/drivers/scsi/be2iscsi/be_mgmt.c +++ b/drivers/scsi/be2iscsi/be_mgmt.c @@ -1085,8 +1085,10 @@ unsigned int beiscsi_boot_get_sinfo(struct beiscsi_hba *phba) nonemb_cmd->va = pci_alloc_consistent(phba->ctrl.pdev, sizeof(nonemb_cmd->size), &nonemb_cmd->dma); - if (!nonemb_cmd->va) + if (!nonemb_cmd->va) { + mutex_unlock(&ctrl->mbox_lock); return 0; + } req = nonemb_cmd->va; memset(req, 0, sizeof(*req));