korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-04 09:34:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

media: mantis: fix two smatch errors

Browse Source 
Drop two dprintk's that relied on a non-NULL mantis pointer
when it was in fact a NULL pointer.

Fix those warnings:

drivers/media/pci/mantis/mantis_cards.c:73 mantis_irq_handler() error: we previously assumed 'mantis' could be null (see line 72)
drivers/media/pci/mantis/hopper_cards.c:64 hopper_irq_handler() error: we previously assumed 'mantis' could be null (see line 63)

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
This commit is contained in:
Hans Verkuil 2019-11-03 12:23:38 +01:00 committed by Mauro Carvalho Chehab
parent b5f72a17b1
commit 61b8584a2f
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/pci/mantis/hopper_cards.c
View File

@ -60,10 +60,8 @@ static irqreturn_t hopper_irq_handler(int irq, void *dev_id)
struct mantis_ca *ca; struct mantis_ca *ca;
mantis = (struct mantis_pci *) dev_id; mantis = (struct mantis_pci *) dev_id;
if (unlikely(!mantis)) { if (unlikely(!mantis))
dprintk(MANTIS_ERROR, 1, "Mantis == NULL");
return IRQ_NONE; return IRQ_NONE;
}
ca = mantis->mantis_ca; ca = mantis->mantis_ca;
stat = mmread(MANTIS_INT_STAT); stat = mmread(MANTIS_INT_STAT);

4
drivers/media/pci/mantis/mantis_cards.c
View File

@ -69,10 +69,8 @@ static irqreturn_t mantis_irq_handler(int irq, void *dev_id)
struct mantis_ca *ca; struct mantis_ca *ca;
mantis = (struct mantis_pci *) dev_id; mantis = (struct mantis_pci *) dev_id;
if (unlikely(mantis == NULL)) { if (unlikely(!mantis))
dprintk(MANTIS_ERROR, 1, "Mantis == NULL");
return IRQ_NONE; return IRQ_NONE;
}
ca = mantis->mantis_ca; ca = mantis->mantis_ca;
stat = mmread(MANTIS_INT_STAT); stat = mmread(MANTIS_INT_STAT);