korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-15 16:24:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

leds: lm36274: use devres LED registering function

Browse Source 
Now that the potential use-after-free issue is resolved we can use
devres for LED registration in this driver.

By using devres version of LED registering function we can remove the
.remove method from this driver.

Signed-off-by: Marek Behún <marek.behun@nic.cz>
Tested-by: Dan Murphy <dmurphy@ti.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
This commit is contained in:
Marek Behún 2020-09-19 20:03:01 +02:00 committed by Pavel Machek
parent 5c0d20a968
commit 60bbd9d411
1 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/leds/leds-lm36274.c
View File

@ -142,7 +142,8 @@ static int lm36274_probe(struct platform_device *pdev)
chip->led_dev.max_brightness = MAX_BRIGHTNESS_11BIT; chip->led_dev.max_brightness = MAX_BRIGHTNESS_11BIT;
chip->led_dev.brightness_set_blocking = lm36274_brightness_set; chip->led_dev.brightness_set_blocking = lm36274_brightness_set;
ret = led_classdev_register_ext(chip->dev, &chip->led_dev, &init_data); ret = devm_led_classdev_register_ext(chip->dev, &chip->led_dev,
&init_data);
if (ret) if (ret)
dev_err(chip->dev, "Failed to register LED for node %pfw\n", dev_err(chip->dev, "Failed to register LED for node %pfw\n",
init_data.fwnode); init_data.fwnode);
@ -152,15 +153,6 @@ static int lm36274_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int lm36274_remove(struct platform_device *pdev)
{
struct lm36274 *chip = platform_get_drvdata(pdev);
led_classdev_unregister(&chip->led_dev);
return 0;
}
static const struct of_device_id of_lm36274_leds_match[] = { static const struct of_device_id of_lm36274_leds_match[] = {
{ .compatible = "ti,lm36274-backlight", }, { .compatible = "ti,lm36274-backlight", },
{}, {},
@ -169,7 +161,6 @@ MODULE_DEVICE_TABLE(of, of_lm36274_leds_match);
static struct platform_driver lm36274_driver = { static struct platform_driver lm36274_driver = {
.probe = lm36274_probe, .probe = lm36274_probe,
.remove = lm36274_remove,
.driver = { .driver = {
.name = "lm36274-leds", .name = "lm36274-leds",
}, },