korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-11 04:18:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

ASoC: mediatek: mt8365: check validity before usage of i2s_data

Browse Source 
There may be a case where i2s_data may not get initialized by the for
loop which will cause the kernel crash. Initialize the i2s_data to NULL
and abort execute if it isn't found.

Fixes: 402bbb13a1 ("ASoC: mediatek: mt8365: Add I2S DAI support")
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://patch.msgid.link/20240911111317.4072349-1-usama.anjum@collabora.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Muhammad Usama Anjum 2024-09-11 16:13:07 +05:00 committed by Mark Brown
parent 0b0aa67baa
commit 5c4e15e632
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sound/soc/mediatek/mt8365/mt8365-dai-i2s.c
View File

@ -465,13 +465,16 @@ void mt8365_afe_set_i2s_out_enable(struct mtk_base_afe *afe, bool enable)
int i; int i;
unsigned long flags; unsigned long flags;
struct mt8365_afe_private *afe_priv = afe->platform_priv; struct mt8365_afe_private *afe_priv = afe->platform_priv;
struct mtk_afe_i2s_priv *i2s_data; struct mtk_afe_i2s_priv *i2s_data = NULL;
for (i = 0; i < DAI_I2S_NUM; i++) { for (i = 0; i < DAI_I2S_NUM; i++) {
if (mt8365_i2s_priv[i].adda_link) if (mt8365_i2s_priv[i].adda_link)
i2s_data = afe_priv->dai_priv[mt8365_i2s_priv[i].id]; i2s_data = afe_priv->dai_priv[mt8365_i2s_priv[i].id];
} }
if (!i2s_data)
return;
spin_lock_irqsave(&afe_priv->afe_ctrl_lock, flags); spin_lock_irqsave(&afe_priv->afe_ctrl_lock, flags);
if (enable) { if (enable) {