korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-11 21:38:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

iio: adc: Fix incorrect exit of for-loop

Browse Source 
Currently the for-loop that scans for the optimial adc_period iterates
through all the possible adc_period levels because the exit logic in
the loop is inverted. I believe the comparison should be swapped and
the continue replaced with a break to exit the loop at the correct
point.

Addresses-Coverity: ("Continue has no effect")
Fixes: e08e19c331 ("iio:adc: add iio driver for Palmas (twl6035/7) gpadc")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210730071651.17394-1-colin.king@canonical.com
Cc: <stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Colin Ian King 2021-07-30 08:16:51 +01:00 committed by Jonathan Cameron
parent 84edec86f4
commit 5afc1540f1
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/iio/adc/palmas_gpadc.c
View File

@ -664,8 +664,8 @@ static int palmas_adc_wakeup_configure(struct palmas_gpadc *adc)
adc_period = adc->auto_conversion_period; adc_period = adc->auto_conversion_period;
for (i = 0; i < 16; ++i) { for (i = 0; i < 16; ++i) {
if (((1000 * (1 << i)) / 32) < adc_period) if (((1000 * (1 << i)) / 32) >= adc_period)
continue; break;
} }
if (i > 0) if (i > 0)
i--; i--;