hso modem detect fix patch against Alan Cox'es tty tree

Fixed incorrect check for the modem port, this prevents
crashes caused by issueing a tiocmget_submit_urb
on endpoints which don't exist for non modem devices.

Signed-off-by: Denis Joseph Barrow <D.Barow@option.com>
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Denis Joseph Barrow 2009-01-02 13:50:29 +00:00 committed by Linus Torvalds
parent ad36b88e2d
commit 58eb17f155

View File

@ -2663,7 +2663,7 @@ static struct hso_device *hso_create_bulk_serial_device(
serial->parent = hso_dev; serial->parent = hso_dev;
hso_dev->port_data.dev_serial = serial; hso_dev->port_data.dev_serial = serial;
if (port & HSO_PORT_MODEM) { if ((port & HSO_PORT_MASK) == HSO_PORT_MODEM) {
num_urbs = 2; num_urbs = 2;
serial->tiocmget = kzalloc(sizeof(struct hso_tiocmget), serial->tiocmget = kzalloc(sizeof(struct hso_tiocmget),
GFP_KERNEL); GFP_KERNEL);