Clean-up for omaps for v6.5

Two patches for checkpatch warnings, and one change to use pr_err instead
 of printk.
 -----BEGIN PGP SIGNATURE-----
 
 iQJFBAABCAAvFiEEkgNvrZJU/QSQYIcQG9Q+yVyrpXMFAmR9gB4RHHRvbnlAYXRv
 bWlkZS5jb20ACgkQG9Q+yVyrpXOfzRAApeqV9RL/2FoSrPrNll8udyHFHY4rnAYm
 e3wIljWjQEQN0Kar8s2i74cQlUkEWhgScH6SOR0DeHdKS9u/fqJtzYtnJjc2t7xF
 +RIHlZD3YZVV5fQpvLDbraPqKE+zajHPCeV7hXICZKc2WpbWTmQ4rZsAWvkKS7QM
 A6/Fi6fjGVkWLWS3t4jilo/hesP15m8FsPnDnXlR98OdX1xZ6Lt2FtqVbjpCce75
 KKudVMShiftgsO029BNRrQ6q50LEC3cSDo+LER2Q8VqR7UfpbdhEDwCRkCqdbKVD
 IY6wC7XWPEjU5BxUnXP9v8cyNlpPdWJaIP1HwfAt0aYB4kqtM2vDzgY5T31P00er
 5dfkW9zRA5KDUeAwO5eHVQbirz+gfRlrs4qM9Xvkb+7H9RxHy22eWlNUR9sp9ua0
 IUvc5P8y02d6vM/S5yZnRtlVSF2r8ueiALuEhP93zK1uZPmnyz+uDEi6e3g6tAFR
 bIX6UequevcZdjClyA7JI2xGMTKK3WmQ+NTZxvVF0tG4q3DZurLSco+HGnU9Xft9
 WJfCPSzIWk+CT2soCtXr7G5G0XIJi611fLITNSFwbNHr6peilBlzPPP93F0jWVVm
 M8Mzl1bdnKXUKg6KdW/JJHDtGCY8oSno9K6CvmcyGy6ajjo+BiN7I68H7oBk+fo8
 ll5tx9nBVeI=
 =QbGV
 -----END PGP SIGNATURE-----
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCgAdFiEEiK/NIGsWEZVxh/FrYKtH/8kJUicFAmSAYnAACgkQYKtH/8kJ
 UicAaRAAnpamrXsSgLtxis9822pDBube3Pr0aUnrDbyToRr0Rr0oaC8qw2OJ40A2
 9b06VtS6wMbhh/+MJDJG5kaIwfqpJeaaS4lfOsuwaTQ4VqgzsSBt5tFakmp45gmv
 7mwQbgOVgBZp80gjyGTaancv9h1mBGCXfXDhDHz3pSnNOynHNEqDWfKnz5hWvl4a
 J/wzHmSrUuUpVSpLsgRZ5+kgBJU2l7oD6QFjorMA+knVkobFnObOkFtiTs8FLmj9
 1jX6pzDTcig5rNWivJdEM2Pxhqfp3q1n+mJHVlgj/1EwVKFokLbnMX8itEJT9QoY
 FxNgeljdr0QaMz3v0y6nYIIuegZRduQ5v8ngIEHLyE9LEP0XwFPmxd16Q81RMuo0
 w5lVIMV3SfaBf7GYoR9yQC4bEuurKkDpKEbrbpeIGVOECj3H3A+PQIFxyZ25bfgQ
 FksQ5kQTgrhFtzGIfB82O2U1kpCeAs5stSMshRrx1OWgr1xjyE95beuyByOEboN8
 Pb3szergiAcEWE1N83lZJyvewmaFckcg/i1rG27YWm7xePGYb13ee/vSW72ugmSS
 /qFOUfOZJw4QLo7cTBOpIakRVoqk4XdkEMiYmL3qhLY4N2jzpsqk30MvQbNl5dN3
 9QJqpGMFnDoBXfqScLnH1HdlscVfpM7ipUUnDdX1kbKNdU+0p0M=
 =6THM
 -----END PGP SIGNATURE-----

Merge tag 'omap-for-v6.5/cleanup-signed' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap into soc/arm

Clean-up for omaps for v6.5

Two patches for checkpatch warnings, and one change to use pr_err instead
of printk.

* tag 'omap-for-v6.5/cleanup-signed' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap:
  ARM: omap2: Fix checkpatch issues
  arm: omap1: replace printk() with pr_err macro
  ARM: omap: Fix checkpatch issues

Link: https://lore.kernel.org/r/pull-1685946511-835910@atomide.com
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This commit is contained in:
Arnd Bergmann 2023-06-07 12:56:47 +02:00
commit 54cb981c29
8 changed files with 18 additions and 19 deletions

View File

@ -632,7 +632,7 @@ static int __init omap_pm_init(void)
error = sysfs_create_file(power_kobj, &sleep_while_idle_attr.attr);
if (error)
printk(KERN_ERR "sysfs_create_file failed: %d\n", error);
pr_err("sysfs_create_file failed: %d\n", error);
if (cpu_is_omap16xx()) {
/* configure LOW_PWR pin */

View File

@ -23,7 +23,7 @@
#define OMAP1_SRAM_PA 0x20000000
#define SRAM_BOOTLOADER_SZ 0x80
#define ROUND_DOWN(value,boundary) ((value) & (~((boundary)-1)))
#define ROUND_DOWN(value, boundary) ((value) & (~((boundary) - 1)))
static void __iomem *omap_sram_base;
static unsigned long omap_sram_start;

View File

@ -374,6 +374,7 @@ static void irq_restore_context(void)
static void irq_save_secure_context(void)
{
u32 ret;
ret = omap_secure_dispatcher(OMAP4_HAL_SAVEGIC_INDEX,
FLAG_START_CRITICAL,
0, 0, 0, 0, 0);

View File

@ -1851,7 +1851,7 @@ static struct omap_hwmod_ocp_if omap3xxx_l4_core__dss_rfbi = {
.fw = {
.omap2 = {
.l4_fw_region = OMAP3_L4_CORE_FW_DSS_RFBI_REGION,
.l4_prot_group = OMAP3_L4_CORE_FW_DSS_PROT_GROUP ,
.l4_prot_group = OMAP3_L4_CORE_FW_DSS_PROT_GROUP,
.flags = OMAP_FIREWALL_L4,
},
},
@ -2172,7 +2172,7 @@ static struct omap_hwmod am35xx_emac_hwmod = {
/*
* According to Mark Greer, the MPU will not return from WFI
* when the EMAC signals an interrupt.
* http://www.spinics.net/lists/arm-kernel/msg174734.html
* https://lore.kernel.org/all/1336770778-23044-3-git-send-email-mgreer@animalcreek.com/
*/
.flags = (HWMOD_NO_IDLEST | HWMOD_BLOCK_WFI),
};
@ -2346,13 +2346,12 @@ static struct omap_hwmod_ocp_if *omap36xx_sham_hwmod_ocp_ifs[] __initdata = {
NULL
};
/*
* Apparently the SHA/MD5 and AES accelerator IP blocks are
* only present on some AM35xx chips, and no one knows which
* ones. See
* http://www.spinics.net/lists/arm-kernel/msg215466.html So
* if you need these IP blocks on an AM35xx, try uncommenting
* ones.
* See https://lore.kernel.org/all/20130108203853.GB1876@animalcreek.com/
* So if you need these IP blocks on an AM35xx, try uncommenting
* the following lines.
*/
static struct omap_hwmod_ocp_if *am35xx_sham_hwmod_ocp_ifs[] __initdata = {

View File

@ -1,11 +1,11 @@
// SPDX-License-Identifier: GPL-2.0-or-later
/*
* This file configures the internal USB PHY in OMAP4430. Used
* with TWL6030 transceiver and MUSB on OMAP4430.
*
* Copyright (C) 2010 Texas Instruments Incorporated - https://www.ti.com
* Author: Hema HK <hemahk@ti.com>
*/
* This file configures the internal USB PHY in OMAP4430. Used
* with TWL6030 transceiver and MUSB on OMAP4430.
*
* Copyright (C) 2010 Texas Instruments Incorporated - https://www.ti.com
* Author: Hema HK <hemahk@ti.com>
*/
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

View File

@ -1,7 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
* linux/arch/arm/mach-omap2/sdrc2xxx.c
*
* SDRAM timing related functions for OMAP2xxx
*
* Copyright (C) 2005, 2008 Texas Instruments Inc.

View File

@ -45,7 +45,7 @@
#define GP_DEVICE 0x300
#define ROUND_DOWN(value,boundary) ((value) & (~((boundary)-1)))
#define ROUND_DOWN(value, boundary) ((value) & (~((boundary) - 1)))
static unsigned long omap_sram_start;
static unsigned long omap_sram_size;
@ -118,7 +118,7 @@ static void omap_sram_reset(void)
*/
static int is_sram_locked(void)
{
if (OMAP2_DEVICE_TYPE_GP == omap_type()) {
if (omap_type() == OMAP2_DEVICE_TYPE_GP) {
/* RAMFW: R/W access to all initiators for all qualifier sets */
if (cpu_is_omap242x()) {
writel_relaxed(0xFF, OMAP24XX_VA_REQINFOPERM0); /* all q-vects */

View File

@ -26,5 +26,6 @@ void ti81xx_restart(enum reboot_mode mode, const char *cmd)
{
omap2_prm_set_mod_reg_bits(TI81XX_GLOBAL_RST_COLD, 0,
TI81XX_PRM_DEVICE_RSTCTRL);
while (1);
while (1)
;
}