korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-30 07:34:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

net: myri10ge: use skb_list_walk_safe helper for gso segments

Browse Source 
This is a straight-forward conversion case for the new function, and
while we're at it, we can remove a null write to skb->next by replacing
it with skb_mark_not_on_list.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jason A. Donenfeld 2020-01-08 16:59:08 -05:00 committed by David S. Miller
parent 69b4ed5cbf
commit 536577f36f
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/ethernet/myricom/myri10ge/myri10ge.c
View File

@ -2892,7 +2892,7 @@ drop:
static netdev_tx_t myri10ge_sw_tso(struct sk_buff *skb, static netdev_tx_t myri10ge_sw_tso(struct sk_buff *skb,
struct net_device *dev) struct net_device *dev)
{ {
struct sk_buff *segs, *curr; struct sk_buff *segs, *curr, *next;
struct myri10ge_priv *mgp = netdev_priv(dev); struct myri10ge_priv *mgp = netdev_priv(dev);
struct myri10ge_slice_state *ss; struct myri10ge_slice_state *ss;
netdev_tx_t status; netdev_tx_t status;
@ -2901,10 +2901,8 @@ static netdev_tx_t myri10ge_sw_tso(struct sk_buff *skb,
if (IS_ERR(segs)) if (IS_ERR(segs))
goto drop; goto drop;
while (segs) { skb_list_walk_safe(segs, curr, next) {
curr = segs; skb_mark_not_on_list(curr);
segs = segs->next;
curr->next = NULL;
status = myri10ge_xmit(curr, dev); status = myri10ge_xmit(curr, dev);
if (status != 0) { if (status != 0) {
dev_kfree_skb_any(curr); dev_kfree_skb_any(curr);