korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-16 00:34:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

memory: emif: Add check for setup_interrupts

Browse Source 
[ Upstream commit fd7bd80b46 ]

As the potential failure of the devm_request_threaded_irq(),
it should be better to check the return value of the
setup_interrupts() and return error if fails.

Fixes: 68b4aee35d ("memory: emif: add interrupt and temperature handling")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Link: https://lore.kernel.org/r/20220224025444.3256530-1-jiasheng@iscas.ac.cn
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Jiasheng Jiang 2022-02-24 10:54:44 +08:00 committed by Greg Kroah-Hartman
parent fc237b8d62
commit 50d934cea5
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/memory/emif.c
View File

@ -1117,7 +1117,7 @@ static int __init_or_module emif_probe(struct platform_device *pdev)
{ {
struct emif_data *emif; struct emif_data *emif;
struct resource *res; struct resource *res;
int irq; int irq, ret;
if (pdev->dev.of_node) if (pdev->dev.of_node)
emif = of_get_memory_device_details(pdev->dev.of_node, &pdev->dev); emif = of_get_memory_device_details(pdev->dev.of_node, &pdev->dev);
@ -1147,7 +1147,9 @@ static int __init_or_module emif_probe(struct platform_device *pdev)
emif_onetime_settings(emif); emif_onetime_settings(emif);
emif_debugfs_init(emif); emif_debugfs_init(emif);
disable_and_clear_all_interrupts(emif); disable_and_clear_all_interrupts(emif);
setup_interrupts(emif, irq); ret = setup_interrupts(emif, irq);
if (ret)
goto error;
/* One-time actions taken on probing the first device */ /* One-time actions taken on probing the first device */
if (!emif1) { if (!emif1) {