korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2025-01-21 05:14:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

tools/nolibc/stdio: Add format attribute to enable printf warnings

Browse Source 
When we use printf and fprintf functions from the nolibc, we don't
get any warning from the compiler if we have the wrong arguments.
For example, the following calls will compile silently:
```
  printf("%s %s\n", "aaa");
  fprintf(stdout, "%s %s\n", "xxx", 1);
```
(Note the wrong arguments).

Those calls are undefined behavior. The compiler can help us warn
about the above mistakes by adding a `printf` format attribute to
those functions declaration. This patch adds it, and now it yields
these warnings for those mistakes:
```
  warning: format `%s` expects a matching `char *` argument [-Wformat=]
  warning: format `%s` expects argument of type `char *`, but argument 4 has type `int` [-Wformat=]
```

  [ ammarfaizi2: Simplify the attribute placement. ]

Signed-off-by: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Acked-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
This commit is contained in:
Alviro Iskandar Setiawan 2022-05-20 00:21:16 +07:00 committed by Paul E. McKenney
parent 1ef150cf40
commit 4f2c9703a1
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/include/nolibc/stdio.h
View File

@ -273,7 +273,7 @@ int vfprintf(FILE *stream, const char *fmt, va_list args)
return written; return written;
} }
static __attribute__((unused)) static __attribute__((unused, format(printf, 2, 3)))
int fprintf(FILE *stream, const char *fmt, ...) int fprintf(FILE *stream, const char *fmt, ...)
{ {
va_list args; va_list args;
@ -285,7 +285,7 @@ int fprintf(FILE *stream, const char *fmt, ...)
return ret; return ret;
} }
static __attribute__((unused)) static __attribute__((unused, format(printf, 1, 2)))
int printf(const char *fmt, ...) int printf(const char *fmt, ...)
{ {
va_list args; va_list args;