mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-11 04:18:39 +08:00
memory: stm32-fmc2-ebi: simplify with dev_err_probe()
dev_err_probe() combines 'return' and error code printing, thus code is a bit simpler, even if it cannot actually defer. Suggested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Link: https://lore.kernel.org/r/20240816-cleanup-h-of-node-put-memory-v2-6-9eed0ee16b78@linaro.org Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
This commit is contained in:
parent
48ec68281d
commit
4c1a381a9e
@ -1579,11 +1579,8 @@ static int stm32_fmc2_ebi_parse_dt(struct stm32_fmc2_ebi *ebi)
|
||||
|
||||
for_each_available_child_of_node_scoped(dev->of_node, child) {
|
||||
ret = of_property_read_u32(child, "reg", &bank);
|
||||
if (ret) {
|
||||
dev_err(dev, "could not retrieve reg property: %d\n",
|
||||
ret);
|
||||
return ret;
|
||||
}
|
||||
if (ret)
|
||||
return dev_err_probe(dev, ret, "could not retrieve reg property\n");
|
||||
|
||||
if (bank >= FMC2_MAX_BANKS) {
|
||||
dev_err(dev, "invalid reg value: %d\n", bank);
|
||||
@ -1605,11 +1602,9 @@ static int stm32_fmc2_ebi_parse_dt(struct stm32_fmc2_ebi *ebi)
|
||||
|
||||
if (bank < FMC2_MAX_EBI_CE) {
|
||||
ret = stm32_fmc2_ebi_setup_cs(ebi, child, bank);
|
||||
if (ret) {
|
||||
dev_err(dev, "setup chip select %d failed: %d\n",
|
||||
bank, ret);
|
||||
return ret;
|
||||
}
|
||||
if (ret)
|
||||
return dev_err_probe(dev, ret,
|
||||
"setup chip select %d failed\n", bank);
|
||||
}
|
||||
|
||||
ebi->bank_assigned |= BIT(bank);
|
||||
|
Loading…
Reference in New Issue
Block a user