korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2025-01-19 04:14:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

ext3: drop if around WARN_ON

Browse Source 
Just use WARN_ON rather than an if containing only WARN_ON(1).

A simplified version of the semantic patch that makes this transformation
is as follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
@@
- if (e) WARN_ON(1);
+ WARN_ON(e);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Jan Kara <jack@suse.cz>
This commit is contained in:
Julia Lawall 2012-11-03 21:30:21 +01:00 committed by Jan Kara
parent 195c0f96f0
commit 4789775477
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fs/ext3/inode.c
View File

@ -1071,8 +1071,7 @@ struct buffer_head *ext3_getblk(handle_t *handle, struct inode *inode,
* mapped. 0 in case of a HOLE. * mapped. 0 in case of a HOLE.
*/ */
if (err > 0) { if (err > 0) {
if (err > 1) WARN_ON(err > 1);
WARN_ON(1);
err = 0; err = 0;
} }
*errp = err; *errp = err;