korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-18 17:54:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

V4L/DVB (12342): af9015: avoid magically sized temporary buffer in eeprom_dump

Browse Source 
Replace printing to magically sized temporary buffer with use
of KERN_CONT for continual printing of eeprom registers dump.

Since deb_info is defined as dprintk, which is conditionally defined
to printk without additional parameters, meaning that deb_info is equivalent
to direct printk (without adding KERN_ facility), we can use KERN_DEBUG and
KERN_CONT in there, eliminating the need for sprintf into temporary buffer
with not easily readable/magical size.

Though it's strange, that deb_info definition uses printk without KERN_
facility and callers don't use it either.

Signed-off-by: Jan Nikitenko <jan.nikitenko@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Jan Nikitenko 2009-07-27 19:05:19 -03:00 committed by Mauro Carvalho Chehab
parent 1420d498fd
commit 43f8de7ac6
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/media/dvb/dvb-usb/af9015.c
View File

@ -538,24 +538,22 @@ exit:
/* dump eeprom */ /* dump eeprom */
static int af9015_eeprom_dump(struct dvb_usb_device *d) static int af9015_eeprom_dump(struct dvb_usb_device *d)
{ {
char buf[4+3*16+1], buf2[4];
u8 reg, val; u8 reg, val;
for (reg = 0; ; reg++) { for (reg = 0; ; reg++) {
if (reg % 16 == 0) { if (reg % 16 == 0) {
if (reg) if (reg)
deb_info("%s\n", buf); deb_info(KERN_CONT "\n");
sprintf(buf, "%02x: ", reg); deb_info(KERN_DEBUG "%02x:", reg);
} }
if (af9015_read_reg_i2c(d, AF9015_I2C_EEPROM, reg, &val) == 0) if (af9015_read_reg_i2c(d, AF9015_I2C_EEPROM, reg, &val) == 0)
sprintf(buf2, "%02x ", val); deb_info(KERN_CONT " %02x", val);
else else
strcpy(buf2, "-- "); deb_info(KERN_CONT " --");
strcat(buf, buf2);
if (reg == 0xff) if (reg == 0xff)
break; break;
} }
deb_info("%s\n", buf); deb_info(KERN_CONT "\n");
return 0; return 0;
} }