korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-12 05:24:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

memory: brcmstb_dpfe: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Markus Mayer <mmayer@broadcom.com>
Link: https://lore.kernel.org/r/94780e5a414b20b6effa1e87208c14620c854e88.1702822744.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
This commit is contained in:
Uwe Kleine-König 2023-12-17 15:29:27 +01:00 committed by Krzysztof Kozlowski
parent 4a23d0f981
commit 431187eadb
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/memory/brcmstb_dpfe.c
View File

@ -909,13 +909,11 @@ static int brcmstb_dpfe_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int brcmstb_dpfe_remove(struct platform_device *pdev) static void brcmstb_dpfe_remove(struct platform_device *pdev)
{ {
struct brcmstb_dpfe_priv *priv = dev_get_drvdata(&pdev->dev); struct brcmstb_dpfe_priv *priv = dev_get_drvdata(&pdev->dev);
sysfs_remove_groups(&pdev->dev.kobj, priv->dpfe_api->sysfs_attrs); sysfs_remove_groups(&pdev->dev.kobj, priv->dpfe_api->sysfs_attrs);
return 0;
} }
static const struct of_device_id brcmstb_dpfe_of_match[] = { static const struct of_device_id brcmstb_dpfe_of_match[] = {
@ -936,7 +934,7 @@ static struct platform_driver brcmstb_dpfe_driver = {
.of_match_table = brcmstb_dpfe_of_match, .of_match_table = brcmstb_dpfe_of_match,
}, },
.probe = brcmstb_dpfe_probe, .probe = brcmstb_dpfe_probe,
.remove = brcmstb_dpfe_remove, .remove_new = brcmstb_dpfe_remove,
.resume = brcmstb_dpfe_resume, .resume = brcmstb_dpfe_resume,
}; };