korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2025-01-16 19:04:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

staging: unisys: visorbus: Remove unneeded checks for valid variable addr

Browse Source 
The 'retry' variable created in handle_command() is statically allocated,
and its address is never set to NULL. Therefore conditionals to verify
the validity of the retry variable's address are unnecessary.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Binder <david.binder@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
David Binder 2016-12-22 11:09:00 -05:00 committed by Greg Kroah-Hartman
parent 36309d3b10
commit 3e4273db10
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/staging/unisys/visorbus/visorchipset.c
View File

@ -1852,8 +1852,7 @@ parser_init_byte_stream(u64 addr, u32 bytes, bool local, bool *retry)
int allocbytes = sizeof(struct parser_context) + bytes; int allocbytes = sizeof(struct parser_context) + bytes;
struct parser_context *ctx; struct parser_context *ctx;
if (retry) *retry = false;
*retry = false;
/* /*
* alloc an 0 extra byte to ensure payload is * alloc an 0 extra byte to ensure payload is
@ -1862,14 +1861,12 @@ parser_init_byte_stream(u64 addr, u32 bytes, bool local, bool *retry)
allocbytes++; allocbytes++;
if ((controlvm_payload_bytes_buffered + bytes) if ((controlvm_payload_bytes_buffered + bytes)
> MAX_CONTROLVM_PAYLOAD_BYTES) { > MAX_CONTROLVM_PAYLOAD_BYTES) {
if (retry) *retry = true;
*retry = true;
return NULL; return NULL;
} }
ctx = kzalloc(allocbytes, GFP_KERNEL | __GFP_NORETRY); ctx = kzalloc(allocbytes, GFP_KERNEL | __GFP_NORETRY);
if (!ctx) { if (!ctx) {
if (retry) *retry = true;
*retry = true;
return NULL; return NULL;
} }