korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-23 12:14:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

ALSA: usb-audio: US16x08: Move overflow check before array access

Browse Source 
Buffer overflow could occur in the loop "while", due to accessing an
array element before checking the index.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Daniil Dementev <d.dementev@ispras.ru>
Reviewed-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Link: https://lore.kernel.org/r/20220610165732.2904-1-d.dementev@ispras.ru
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Daniil Dementev 2022-06-10 19:57:32 +03:00 committed by Takashi Iwai
parent b2e6b3d9bb
commit 3ddbe35d9a
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sound/usb/mixer_us16x08.c
View File

@ -637,10 +637,10 @@ static int snd_get_meter_comp_index(struct snd_us16x08_meter_store *store)
} }
} else { } else {
/* skip channels with no compressor active */ /* skip channels with no compressor active */
while (!store->comp_store->val[ while (store->comp_index <= SND_US16X08_MAX_CHANNELS
&& !store->comp_store->val[
COMP_STORE_IDX(SND_US16X08_ID_COMP_SWITCH)] COMP_STORE_IDX(SND_US16X08_ID_COMP_SWITCH)]
[store->comp_index - 1] [store->comp_index - 1]) {
&& store->comp_index <= SND_US16X08_MAX_CHANNELS) {
store->comp_index++; store->comp_index++;
} }
ret = store->comp_index++; ret = store->comp_index++;