korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-19 00:54:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

drm/nouveau: uvmm: remove incorrect calls to mas_unlock()

Browse Source 
Remove incorrect calls to mas_unlock() in the unwind path of
__nouveau_uvma_region_insert(). The region maple tree uses an external
lock instead, namely the global uvmm lock.

Fixes: b88baab828 ("drm/nouveau: implement new VM_BIND uAPI")
Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Danilo Krummrich <dakr@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230807163238.2091-5-dakr@redhat.com
This commit is contained in:
Danilo Krummrich 2023-08-07 18:32:25 +02:00
parent e39701e33a
commit 3cbc772107
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/gpu/drm/nouveau/nouveau_uvmm.c
View File

@ -279,15 +279,11 @@ __nouveau_uvma_region_insert(struct nouveau_uvmm *uvmm,
u64 last = addr + range - 1;
MA_STATE(mas, &uvmm->region_mt, addr, addr);
if (unlikely(mas_walk(&mas))) {
mas_unlock(&mas);
if (unlikely(mas_walk(&mas)))
return -EEXIST;
}
if (unlikely(mas.last < last)) {
mas_unlock(&mas);
if (unlikely(mas.last < last))
return -EEXIST;
}
mas.index = addr;
mas.last = last;