korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-11 12:28:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

memcg: optimize the "Search everything else" loop in mm_update_next_owner()

Browse Source 
for_each_process_thread() is sub-optimal. All threads share the same
->mm, we can swicth to the next process once we found a thread with
->mm != NULL and ->mm != mm.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Michal Hocko <mhocko@suse.cz>
Cc: Balbir Singh <bsingharora@gmail.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Michal Hocko <mhocko@suse.cz>
Cc: Peter Chiang <pchiang@nvidia.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Oleg Nesterov 2014-06-04 16:07:54 -07:00 committed by Linus Torvalds
parent f87fb599ae
commit 39af1765f1
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
kernel/exit.c
View File

@ -397,9 +397,15 @@ retry:
/* /*
* Search through everything else, we should not get here often. * Search through everything else, we should not get here often.
*/ */
for_each_process_thread(g, c) { for_each_process(g) {
if (!(c->flags & PF_KTHREAD) && c->mm == mm) if (g->flags & PF_KTHREAD)
goto assign_new_owner; continue;
for_each_thread(g, c) {
if (c->mm == mm)
goto assign_new_owner;
if (c->mm)
break;
}
} }
read_unlock(&tasklist_lock); read_unlock(&tasklist_lock);
/* /*