mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-05 10:04:12 +08:00
platform/x86: acer-wmi: Mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warnings: drivers/platform/x86/acer-wmi.c: In function ‘set_u32’: drivers/platform/x86/acer-wmi.c:1378:33: warning: this statement may fall through [-Wimplicit-fallthrough=] if (cap == ACER_CAP_WIRELESS || ^ drivers/platform/x86/acer-wmi.c:1386:3: note: here case ACER_WMID: ^~~~ drivers/platform/x86/acer-wmi.c:1393:12: warning: this statement may fall through [-Wimplicit-fallthrough=] else if (wmi_has_guid(WMID_GUID2)) ^ drivers/platform/x86/acer-wmi.c:1395:3: note: here default: ^~~~~~~ drivers/platform/x86/acer-wmi.c: In function ‘get_u32’: drivers/platform/x86/acer-wmi.c:1340:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (cap == ACER_CAP_MAILLED) { ^ drivers/platform/x86/acer-wmi.c:1344:2: note: here case ACER_WMID: ^~~~ drivers/platform/x86/acer-wmi.c: In function ‘WMID_get_u32’: drivers/platform/x86/acer-wmi.c:1013:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (quirks->mailled == 1) { ^ drivers/platform/x86/acer-wmi.c:1018:2: note: here default: ^~~~~~~ Warning level 3 was used: -Wimplicit-fallthrough=3 This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
This commit is contained in:
parent
6d789e60c3
commit
368bae8788
@ -1014,6 +1014,7 @@ static acpi_status WMID_get_u32(u32 *value, u32 cap)
|
||||
*value = tmp & 0x1;
|
||||
return 0;
|
||||
}
|
||||
/* fall through */
|
||||
default:
|
||||
return AE_ERROR;
|
||||
}
|
||||
@ -1340,6 +1341,7 @@ static acpi_status get_u32(u32 *value, u32 cap)
|
||||
status = AMW0_get_u32(value, cap);
|
||||
break;
|
||||
}
|
||||
/* fall through */
|
||||
case ACER_WMID:
|
||||
status = WMID_get_u32(value, cap);
|
||||
break;
|
||||
@ -1382,6 +1384,7 @@ static acpi_status set_u32(u32 value, u32 cap)
|
||||
|
||||
return AMW0_set_u32(value, cap);
|
||||
}
|
||||
/* fall through */
|
||||
case ACER_WMID:
|
||||
return WMID_set_u32(value, cap);
|
||||
case ACER_WMID_v2:
|
||||
@ -1391,6 +1394,7 @@ static acpi_status set_u32(u32 value, u32 cap)
|
||||
return wmid_v2_set_u32(value, cap);
|
||||
else if (wmi_has_guid(WMID_GUID2))
|
||||
return WMID_set_u32(value, cap);
|
||||
/* fall through */
|
||||
default:
|
||||
return AE_BAD_PARAMETER;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user