korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-04 09:34:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

ALSA: pcmtest: Don't use static storage to track per device data

Browse Source 
While there is probably only ever a single instance of such a pcmtst
device, it's still bad style to use a static variable to store per
device data. Make use of platform_get_drvdata() and
platform_set_drvdata() which fixes a data corruption if there should be
two or more such devices (or this driver is used as a template for
another driver).

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Ivan Orlov <ivan.orlov0322@gmail.com>
Link: https://lore.kernel.org/r/20230707075058.3402832-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Uwe Kleine-König 2023-07-07 09:50:58 +02:00 committed by Takashi Iwai
parent cb2bffdea2
commit 35bc3efb31
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
sound/drivers/pcmtest.c
View File

@ -110,8 +110,6 @@ struct pcmtst_buf_iter {
struct timer_list timer_instance; struct timer_list timer_instance;
}; };
static struct pcmtst *pcmtst;
static struct snd_pcm_hardware snd_pcmtst_hw = { static struct snd_pcm_hardware snd_pcmtst_hw = {
.info = (SNDRV_PCM_INFO_INTERLEAVED | .info = (SNDRV_PCM_INFO_INTERLEAVED |
SNDRV_PCM_INFO_BLOCK_TRANSFER | SNDRV_PCM_INFO_BLOCK_TRANSFER |
@ -552,6 +550,7 @@ _err_free_chip:
static int pcmtst_probe(struct platform_device *pdev) static int pcmtst_probe(struct platform_device *pdev)
{ {
struct snd_card *card; struct snd_card *card;
struct pcmtst *pcmtst;
int err; int err;
err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
@ -573,11 +572,15 @@ static int pcmtst_probe(struct platform_device *pdev)
if (err < 0) if (err < 0)
return err; return err;
platform_set_drvdata(pdev, pcmtst);
return 0; return 0;
} }
static void pdev_remove(struct platform_device *dev) static void pdev_remove(struct platform_device *pdev)
{ {
struct pcmtst *pcmtst = platform_get_drvdata(pdev);
snd_pcmtst_free(pcmtst); snd_pcmtst_free(pcmtst);
} }