korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-04 01:24:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

divamnt: BKL pushdown

Browse Source 
Put explicit lock_kernel() calls into maint_open().

Signed-off-by: Jonathan Corbet <corbet@lwn.net>
This commit is contained in:
Jonathan Corbet 2008-05-16 14:17:33 -06:00
parent a237f3bbaa
commit 3462032d66
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/isdn/hardware/eicon/divamnt.c
View File

@ -14,6 +14,7 @@
#include <linux/init.h> #include <linux/init.h>
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/poll.h> #include <linux/poll.h>
#include <linux/smp_lock.h>
#include <asm/uaccess.h> #include <asm/uaccess.h>
#include "platform.h" #include "platform.h"
@ -127,14 +128,19 @@ static unsigned int maint_poll(struct file *file, poll_table * wait)
static int maint_open(struct inode *ino, struct file *filep) static int maint_open(struct inode *ino, struct file *filep)
{ {
int ret;
lock_kernel();
/* only one open is allowed, so we test /* only one open is allowed, so we test
it atomically */ it atomically */
if (test_and_set_bit(0, &opened)) if (test_and_set_bit(0, &opened))
return (-EBUSY); ret = -EBUSY;
else {
filep->private_data = NULL; filep->private_data = NULL;
ret = nonseekable_open(ino, filep);
return nonseekable_open(ino, filep); }
unlock_kernel();
return ret;
} }
static int maint_close(struct inode *ino, struct file *filep) static int maint_close(struct inode *ino, struct file *filep)