mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-11 04:54:13 +08:00
platform/x86: asus-wmi: Use kmemdup rather than duplicating its implementation
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memcpy, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use kmemdup rather than using kmalloc/kzalloc + memcpy. Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
This commit is contained in:
parent
4215484f8e
commit
340f25ff1d
@ -292,12 +292,11 @@ static int asus_wmi_evaluate_method_agfn(const struct acpi_buffer args)
|
||||
* Copy to dma capable address otherwise memory corruption occurs as
|
||||
* bios has to be able to access it.
|
||||
*/
|
||||
input.pointer = kzalloc(args.length, GFP_DMA | GFP_KERNEL);
|
||||
input.pointer = kmemdup(args.pointer, args.length, GFP_DMA | GFP_KERNEL);
|
||||
input.length = args.length;
|
||||
if (!input.pointer)
|
||||
return -ENOMEM;
|
||||
phys_addr = virt_to_phys(input.pointer);
|
||||
memcpy(input.pointer, args.pointer, args.length);
|
||||
|
||||
status = asus_wmi_evaluate_method(ASUS_WMI_METHODID_AGFN,
|
||||
phys_addr, 0, &retval);
|
||||
|
Loading…
Reference in New Issue
Block a user