korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-15 06:55:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

rsi: Fix module dev_oper_mode parameter description

Browse Source 
The module parameters are missing dev_oper_mode 12, BT classic alone,
add it. Moreover, the parameters encode newlines, which ends up being
printed malformed e.g. by modinfo, so fix that too.

However, the module parameter string is duplicated in both USB and SDIO
modules and the dev_oper_mode mode enumeration in those module parameters
is a duplicate of macros used by the driver. Furthermore, the enumeration
is confusing.

So, deduplicate the module parameter string and use __stringify() to
encode the correct mode enumeration values into the module parameter
string. Finally, replace 'Wi-Fi' with 'Wi-Fi alone' and 'BT' with
'BT classic alone' to clarify what those modes really mean.

Fixes: 898b255339 ("rsi: add module parameter operating mode")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Amitkumar Karwar <amit.karwar@redpinesignals.com>
Cc: Angus Ainslie <angus@akkea.ca>
Cc: David S. Miller <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: Karun Eagalapati <karun256@gmail.com>
Cc: Martin Fuzzey <martin.fuzzey@flowbird.group>
Cc: Martin Kepplinger <martink@posteo.de>
Cc: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
Cc: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Cc: Siva Rebbagondla <siva8118@gmail.com>
Cc: netdev@vger.kernel.org
Cc: <stable@vger.kernel.org> # 4.17+
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210916144245.10181-1-marex@denx.de
This commit is contained in:
Marek Vasut 2021-09-16 16:42:45 +02:00 committed by Kalle Valo
parent 72e717500f
commit 31f97cf9f0
3 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/wireless/rsi/rsi_91x_sdio.c
View File

@ -24,10 +24,7 @@
/* Default operating mode is wlan STA + BT */ /* Default operating mode is wlan STA + BT */
static u16 dev_oper_mode = DEV_OPMODE_STA_BT_DUAL; static u16 dev_oper_mode = DEV_OPMODE_STA_BT_DUAL;
module_param(dev_oper_mode, ushort, 0444); module_param(dev_oper_mode, ushort, 0444);
MODULE_PARM_DESC(dev_oper_mode, MODULE_PARM_DESC(dev_oper_mode, DEV_OPMODE_PARAM_DESC);
"1[Wi-Fi], 4[BT], 8[BT LE], 5[Wi-Fi STA + BT classic]\n"
"9[Wi-Fi STA + BT LE], 13[Wi-Fi STA + BT classic + BT LE]\n"
"6[AP + BT classic], 14[AP + BT classic + BT LE]");
/** /**
* rsi_sdio_set_cmd52_arg() - This function prepares cmd 52 read/write arg. * rsi_sdio_set_cmd52_arg() - This function prepares cmd 52 read/write arg.

5
drivers/net/wireless/rsi/rsi_91x_usb.c
View File

@ -25,10 +25,7 @@
/* Default operating mode is wlan STA + BT */ /* Default operating mode is wlan STA + BT */
static u16 dev_oper_mode = DEV_OPMODE_STA_BT_DUAL; static u16 dev_oper_mode = DEV_OPMODE_STA_BT_DUAL;
module_param(dev_oper_mode, ushort, 0444); module_param(dev_oper_mode, ushort, 0444);
MODULE_PARM_DESC(dev_oper_mode, MODULE_PARM_DESC(dev_oper_mode, DEV_OPMODE_PARAM_DESC);
"1[Wi-Fi], 4[BT], 8[BT LE], 5[Wi-Fi STA + BT classic]\n"
"9[Wi-Fi STA + BT LE], 13[Wi-Fi STA + BT classic + BT LE]\n"
"6[AP + BT classic], 14[AP + BT classic + BT LE]");
static int rsi_rx_urb_submit(struct rsi_hw *adapter, u8 ep_num, gfp_t flags); static int rsi_rx_urb_submit(struct rsi_hw *adapter, u8 ep_num, gfp_t flags);

11
drivers/net/wireless/rsi/rsi_hal.h
View File

@ -28,6 +28,17 @@
#define DEV_OPMODE_AP_BT 6 #define DEV_OPMODE_AP_BT 6
#define DEV_OPMODE_AP_BT_DUAL 14 #define DEV_OPMODE_AP_BT_DUAL 14
#define DEV_OPMODE_PARAM_DESC \
__stringify(DEV_OPMODE_WIFI_ALONE) "[Wi-Fi alone], " \
__stringify(DEV_OPMODE_BT_ALONE) "[BT classic alone], " \
__stringify(DEV_OPMODE_BT_LE_ALONE) "[BT LE alone], " \
__stringify(DEV_OPMODE_BT_DUAL) "[BT classic + BT LE alone], " \
__stringify(DEV_OPMODE_STA_BT) "[Wi-Fi STA + BT classic], " \
__stringify(DEV_OPMODE_STA_BT_LE) "[Wi-Fi STA + BT LE], " \
__stringify(DEV_OPMODE_STA_BT_DUAL) "[Wi-Fi STA + BT classic + BT LE], " \
__stringify(DEV_OPMODE_AP_BT) "[Wi-Fi AP + BT classic], " \
__stringify(DEV_OPMODE_AP_BT_DUAL) "[Wi-Fi AP + BT classic + BT LE]"
#define FLASH_WRITE_CHUNK_SIZE (4 * 1024) #define FLASH_WRITE_CHUNK_SIZE (4 * 1024)
#define FLASH_SECTOR_SIZE (4 * 1024) #define FLASH_SECTOR_SIZE (4 * 1024)