mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-24 04:34:08 +08:00
locking/semaphore: Resolve some shadow warnings
Resolve some shadow warnings resulting from using the name jiffies, which is a well-known global. This is not a problem of course, but it could be a trap for someone copying and pasting code, and it just makes W=2 a little cleaner. Signed-off-by: Mark Rustad <mark.d.rustad@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Acked-by: Peter Zijlstra <peterz@infradead.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Link: http://lkml.kernel.org/r/1409739444-13635-1-git-send-email-jeffrey.t.kirsher@intel.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
This commit is contained in:
parent
ae17ea0ec7
commit
315427691c
@ -36,7 +36,7 @@
|
||||
static noinline void __down(struct semaphore *sem);
|
||||
static noinline int __down_interruptible(struct semaphore *sem);
|
||||
static noinline int __down_killable(struct semaphore *sem);
|
||||
static noinline int __down_timeout(struct semaphore *sem, long jiffies);
|
||||
static noinline int __down_timeout(struct semaphore *sem, long timeout);
|
||||
static noinline void __up(struct semaphore *sem);
|
||||
|
||||
/**
|
||||
@ -145,14 +145,14 @@ EXPORT_SYMBOL(down_trylock);
|
||||
/**
|
||||
* down_timeout - acquire the semaphore within a specified time
|
||||
* @sem: the semaphore to be acquired
|
||||
* @jiffies: how long to wait before failing
|
||||
* @timeout: how long to wait before failing
|
||||
*
|
||||
* Attempts to acquire the semaphore. If no more tasks are allowed to
|
||||
* acquire the semaphore, calling this function will put the task to sleep.
|
||||
* If the semaphore is not released within the specified number of jiffies,
|
||||
* this function returns -ETIME. It returns 0 if the semaphore was acquired.
|
||||
*/
|
||||
int down_timeout(struct semaphore *sem, long jiffies)
|
||||
int down_timeout(struct semaphore *sem, long timeout)
|
||||
{
|
||||
unsigned long flags;
|
||||
int result = 0;
|
||||
@ -161,7 +161,7 @@ int down_timeout(struct semaphore *sem, long jiffies)
|
||||
if (likely(sem->count > 0))
|
||||
sem->count--;
|
||||
else
|
||||
result = __down_timeout(sem, jiffies);
|
||||
result = __down_timeout(sem, timeout);
|
||||
raw_spin_unlock_irqrestore(&sem->lock, flags);
|
||||
|
||||
return result;
|
||||
@ -248,9 +248,9 @@ static noinline int __sched __down_killable(struct semaphore *sem)
|
||||
return __down_common(sem, TASK_KILLABLE, MAX_SCHEDULE_TIMEOUT);
|
||||
}
|
||||
|
||||
static noinline int __sched __down_timeout(struct semaphore *sem, long jiffies)
|
||||
static noinline int __sched __down_timeout(struct semaphore *sem, long timeout)
|
||||
{
|
||||
return __down_common(sem, TASK_UNINTERRUPTIBLE, jiffies);
|
||||
return __down_common(sem, TASK_UNINTERRUPTIBLE, timeout);
|
||||
}
|
||||
|
||||
static noinline void __sched __up(struct semaphore *sem)
|
||||
|
Loading…
Reference in New Issue
Block a user