mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-11 21:14:07 +08:00
remoteproc: imx_rproc: Fix refcount mistake in imx_rproc_addr_init
commitdce68a49be
upstream. In imx_rproc_addr_init() strcmp() is performed over the node after the of_node_put() is performed over it. Fix this error by moving of_node_put() calls. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes:5e4c124307
("remoteproc: imx_rproc: support remote cores booted before Linux Kernel") Cc: stable@vger.kernel.org Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru> Link: https://lore.kernel.org/r/20240612131714.12907-1-amishin@t-argos.ru Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
6c9ea3547f
commit
2de4d41862
@ -737,25 +737,29 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
|
||||
continue;
|
||||
}
|
||||
err = of_address_to_resource(node, 0, &res);
|
||||
of_node_put(node);
|
||||
if (err) {
|
||||
dev_err(dev, "unable to resolve memory region\n");
|
||||
of_node_put(node);
|
||||
return err;
|
||||
}
|
||||
|
||||
if (b >= IMX_RPROC_MEM_MAX)
|
||||
if (b >= IMX_RPROC_MEM_MAX) {
|
||||
of_node_put(node);
|
||||
break;
|
||||
}
|
||||
|
||||
/* Not use resource version, because we might share region */
|
||||
priv->mem[b].cpu_addr = devm_ioremap_wc(&pdev->dev, res.start, resource_size(&res));
|
||||
if (!priv->mem[b].cpu_addr) {
|
||||
dev_err(dev, "failed to remap %pr\n", &res);
|
||||
of_node_put(node);
|
||||
return -ENOMEM;
|
||||
}
|
||||
priv->mem[b].sys_addr = res.start;
|
||||
priv->mem[b].size = resource_size(&res);
|
||||
if (!strcmp(node->name, "rsc-table"))
|
||||
priv->rsc_table = priv->mem[b].cpu_addr;
|
||||
of_node_put(node);
|
||||
b++;
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user