korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-05 01:54:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

hwmon: (core) use permission-specific DEVICE_ATTR variants

Browse Source 
Use DEVICE_ATTR_RO for read-only attributes. This simplifies the source
code, improves readbility, and reduces the chance of inconsistencies.

The conversion was done automatically using coccinelle. It was validated
by compiling both the old and the new source code and comparing its text,
data, and bss size.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
[groeck: Updated description]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Julia Lawall 2016-12-22 13:04:45 +01:00 committed by Guenter Roeck
parent c490c63e95
commit 2ab0c6c55e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/hwmon/hwmon.c
View File

@ -63,11 +63,11 @@ struct hwmon_thermal_data {
}; };
static ssize_t static ssize_t
show_name(struct device *dev, struct device_attribute *attr, char *buf) name_show(struct device *dev, struct device_attribute *attr, char *buf)
{ {
return sprintf(buf, "%s\n", to_hwmon_device(dev)->name); return sprintf(buf, "%s\n", to_hwmon_device(dev)->name);
} }
static DEVICE_ATTR(name, S_IRUGO, show_name, NULL); static DEVICE_ATTR_RO(name);
static struct attribute *hwmon_dev_attrs[] = { static struct attribute *hwmon_dev_attrs[] = {
&dev_attr_name.attr, &dev_attr_name.attr,