korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-17 07:54:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

powerpc/powermac/udbg_scc: Add missing of_node_put()s in udbg_scc_init()

Browse Source 
During the iteration of for_each_child_of_node(), we need to call
of_node_put() for the old references stored in to 'ch_def' and 'ch_a'
as their refcounters have been increased in last iteration.

Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220716074344.540049-1-windhl@126.com
This commit is contained in:
Liang He 2022-07-16 15:43:44 +08:00 committed by Michael Ellerman
parent 11373c933d
commit 2378bf144b
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
arch/powerpc/platforms/powermac/udbg_scc.c
View File

@ -81,10 +81,14 @@ void __init udbg_scc_init(int force_scc)
if (path != NULL)
stdout = of_find_node_by_path(path);
for_each_child_of_node(escc, ch) {
if (ch == stdout)
if (ch == stdout) {
of_node_put(ch_def);
ch_def = of_node_get(ch);
if (of_node_name_eq(ch, "ch-a"))
}
if (of_node_name_eq(ch, "ch-a")) {
of_node_put(ch_a);
ch_a = of_node_get(ch);
}
}
if (ch_def == NULL && !force_scc)
goto bail;