korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-18 09:44:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

iscsi-target: return -EINVAL on oversized configfs parameter

Browse Source 
The iSCSI CHAP auth parameters are already copied with respect for
the destination buffer size.  Return -EINVAL instead of silently
truncating the input.

Signed-off-by: Eric Seppanen <eric@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This commit is contained in:
Eric Seppanen 2013-11-21 14:49:56 -08:00 committed by Nicholas Bellinger
parent 374b105797
commit 2306bfb208
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/target/iscsi/iscsi_target_configfs.c
View File

@ -474,7 +474,8 @@ static ssize_t __iscsi_##prefix##_store_##name( \
\ \
if (!capable(CAP_SYS_ADMIN)) \ if (!capable(CAP_SYS_ADMIN)) \
return -EPERM; \ return -EPERM; \
\ if (count >= sizeof(auth->name)) \
return -EINVAL; \
snprintf(auth->name, sizeof(auth->name), "%s", page); \ snprintf(auth->name, sizeof(auth->name), "%s", page); \
if (!strncmp("NULL", auth->name, 4)) \ if (!strncmp("NULL", auth->name, 4)) \
auth->naf_flags &= ~flags; \ auth->naf_flags &= ~flags; \