korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2025-01-03 12:24:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

scsi: ufs: qcom: Fix acquiring the optional reset control line

Browse Source 
On Qcom UFS platforms, the reset control line seems to be optional (for
SoCs like MSM8996 and probably for others too). The current logic tries to
mimic the devm_reset_control_get_optional() API but it also continues the
probe if there is an error with the declared reset line in DT/ACPI.

In an ideal case, if the reset line is not declared in DT/ACPI, the probe
should continue. But if there is problem in acquiring the declared reset
line (like EPROBE_DEFER) it should fail and return the appropriate error
code.

Link: https://lore.kernel.org/r/20220504084212.11605-2-manivannan.sadhasivam@linaro.org
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Manivannan Sadhasivam 2022-05-04 14:12:08 +05:30 committed by Martin K. Petersen
parent 9b5387fe5a
commit 223b17ed76
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/scsi/ufs/ufs-qcom.c
View File

@ -985,13 +985,12 @@ static int ufs_qcom_init(struct ufs_hba *hba)
host->hba = hba; host->hba = hba;
ufshcd_set_variant(hba, host); ufshcd_set_variant(hba, host);
/* Setup the reset control of HCI */ /* Setup the optional reset control of HCI */
host->core_reset = devm_reset_control_get(hba->dev, "rst"); host->core_reset = devm_reset_control_get_optional(hba->dev, "rst");
if (IS_ERR(host->core_reset)) { if (IS_ERR(host->core_reset)) {
err = PTR_ERR(host->core_reset); err = dev_err_probe(dev, PTR_ERR(host->core_reset),
dev_warn(dev, "Failed to get reset control %d\n", err); "Failed to get reset control\n");
host->core_reset = NULL; goto out_variant_clear;
err = 0;
} }
/* Fire up the reset controller. Failure here is non-fatal. */ /* Fire up the reset controller. Failure here is non-fatal. */