korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-18 08:35:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

configfs: replace strncpy with memcpy

Browse Source 
gcc 8.1.0 complains:

fs/configfs/symlink.c:67:3: warning:
	'strncpy' output truncated before terminating nul copying as many
	bytes from a string as its length
fs/configfs/symlink.c: In function 'configfs_get_link':
fs/configfs/symlink.c:63:13: note: length computed here

Using strncpy() is indeed less than perfect since the length of data to
be copied has already been determined with strlen(). Replace strncpy()
with memcpy() to address the warning and optimize the code a little.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
Guenter Roeck 2018-07-01 13:56:54 -07:00 committed by Christoph Hellwig
parent 707c623529
commit 1823342a1f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/configfs/symlink.c
View File

@ -64,7 +64,7 @@ static void fill_item_path(struct config_item * item, char * buffer, int length)
/* back up enough to print this bus id with '/' */ /* back up enough to print this bus id with '/' */
length -= cur; length -= cur;
strncpy(buffer + length,config_item_name(p),cur); memcpy(buffer + length, config_item_name(p), cur);
*(buffer + --length) = '/'; *(buffer + --length) = '/';
} }
} }