korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-04 09:34:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

block: Fix memory leak in rw_copy_check_uvector() handling

Browse Source 
Fix a memory leak in the error handling path of function sg_io()
that is used during the processing of scsi ioctl. Memory already
allocated by rw_copy_check_uvector() needs to be freed correctly.
Detected by Coverity: CID 1128953.

Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Christian Engelmayer 2014-01-19 02:08:49 +01:00 committed by Jens Axboe
parent 5837c80e87
commit 17a05cca99
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
block/scsi_ioctl.c
View File

@ -323,12 +323,14 @@ static int sg_io(struct request_queue *q, struct gendisk *bd_disk,
if (hdr->iovec_count) { if (hdr->iovec_count) {
size_t iov_data_len; size_t iov_data_len;
struct iovec *iov; struct iovec *iov = NULL;
ret = rw_copy_check_uvector(-1, hdr->dxferp, hdr->iovec_count, ret = rw_copy_check_uvector(-1, hdr->dxferp, hdr->iovec_count,
0, NULL, &iov); 0, NULL, &iov);
if (ret < 0) if (ret < 0) {
kfree(iov);
goto out; goto out;
}
iov_data_len = ret; iov_data_len = ret;
ret = 0; ret = 0;